search

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).
MIT License
8 stars 4 forks source link

bugfix: normalise time in sensor meta data #61

Closed Echsecutor closed 2 years ago

Echsecutor commented 2 years ago

fixes #54

RalphTro commented 2 years ago

Dear @Echsecutor ,

Thanks a lot! It almost works now.

During my review (time_stamp branch), I noticed that e.g. sensorMetadata startTime="2019-04-02T13:55:01.000+01:00" endTime="2019-04-02T14:55:00.000+01:00" is converted nicely (in this case -> sensorMetadatastartTime=2019-04-02T12:55:01.000ZendTime=2019-04-02T13:55:00.000Z)

Curiously, there still seems to be an issue with time values of the time attribute within sensorMetadata and sensorReport though. (For instance, sensorMetadatatime=2019-04-02T14:35:00.000+01:00 and sensorReporttime=2019-04-02T14:05:00.000+01:00)

I think after having addressed this, we should be fine. Thanks a lot in advance!

Kind regards, Ralph

Echsecutor commented 2 years ago

aye, also I forgot to adapt the tests. sorry for that, I will re-check

RalphTro commented 2 years ago

Dear @Echsecutor , Would you mind having a second look/adjusting this as soon as you have some bandwidth? Happy to review afterwards then. Many thanks in advance!