Fix collisions resulting from the same value text in different elements or vendor extensions

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).

MIT License

8 stars 4 forks source link

Fix collisions resulting from the same value text in different elements or vendor extensions #8

Closed Echsecutor closed 4 years ago

Echsecutor commented 4 years ago

See https://github.com/RalphTro/epcis-event-hash-generator/blob/master/testFiles/epcisDocWith2DifferentTransformationEvents.xml for an example of two different events which need to get different hashes

Echsecutor commented 4 years ago

Above problem fixed in https://github.com/RalphTro/epcis-event-hash-generator/pull/9 in f681104451e9ea99da1f166a3c87d54fbb205ff4

Remaining to check: vendor extensions

Echsecutor commented 4 years ago

currently vendor extensions are completely ignored leading to collissions

Echsecutor commented 4 years ago

Vendor extensions are now handled (only collecting and sorting values without substructure) 916a165c7150cd5a9bb78019010afad253feaf9b