Issue#84 : round off microsecond upto 3 digit for all timestamps

RalphTro / epcis-event-hash-generator

ALGORITHM and SOFTWARE PROTOTYPE to uniquely identify/validate the integrity of any EPCIS event through a common, syntax-agnostic approach based on hashing. Takes an EPCIS Document (formatted in either XML or JSON-LD) and returns the corresponding hash value(s).

MIT License

8 stars 4 forks source link

Issue#84 : round off microsecond upto 3 digit for all timestamps #86

Closed dakbhavesh closed 1 year ago

dakbhavesh commented 1 year ago

Dear @RalphTro / @Echsecutor,

I fixed the rounding of the microseconds part in all timestamps to address #84. Change is quite simple.

Added new test file specifically for date rounding scenario. Let me know if you want to add more examples.

Appreciate your time for review, Bhavesh

dakbhavesh commented 1 year ago

Dear @RalphTro / @Echsecutor,

A gentle nudge to review and merge this straightforward PR.

Thanks, Bhavesh

RalphTro commented 1 year ago

Dear @dakbhavesh , Many, many thanks! (Also for the nudge - your message two weeks ago bviously escaped my notice). I especially like that you also prepared an example with timestamps appearing at other places. Moreover, I just tried out a corresponding XML file - worked as well.