search

RamParameswaran / pyAFL

Python AFL (Australian Football League) library for collecting/analysing AFL data from AFLtables.com
MIT License
15 stars 10 forks source link

Adelaide Crows team being read in as Port Adelaide for season stats #23

Closed cheese-egg closed 9 months ago

cheese-egg commented 9 months ago

Thanks for this code, it's really useful for my project. However, when I attempt to read in Adelaide Crows season stats using this command

ADE.season_stats(2022)

I get stats for Port Adelaide players. Is this a known issue and is there a way to fix this?

Thank you

RamParameswaran commented 9 months ago

Hi @cheese-egg, yes it's a known issue - someone else started writing a fix, but didn't merge it into the master branch.

But this is a good reminder for me to have another look. I'll see if I can quickly fix it now.

RamParameswaran commented 9 months ago

Indeed I was able to quickly fix it :) I've merged the fix into the master branch of this repo, and I've released a new version to PIP (v0.4.2).

Please let me know if you have any further issues. Closing this issue now. Thanks

cheese-egg commented 9 months ago

Thank you so much for the quick fix Ram.

I will check it later and let you know if there are any issues, but I'm sure it will be fine.

Cheers Dennis

On Wed, 17 Jan 2024 at 04:56, Ram Parameswaran @.***> wrote:

Closed #23 https://github.com/RamParameswaran/pyAFL/issues/23 as completed.

— Reply to this email directly, view it on GitHub https://github.com/RamParameswaran/pyAFL/issues/23#event-11502434533, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFL4LJFUUCKNNCWL2YWTJ2TYO3A4TAVCNFSM6AAAAABB4HNIUOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUYDENBTGQ2TGMY . You are receiving this because you were mentioned.Message ID: @.***>

cheese-egg commented 9 months ago

Hi Ram

I'm not sure if I've missed something here but I can't seem to pip install the latest version you just created. I only seem to be able to get version 0.3.1. Do you have any idea why this might be?

[image: image.png]

Thanks again for your help!

Dennis

On Wed, 17 Jan 2024 at 10:34, Dennis Horton @.***> wrote:

Thank you so much for the quick fix Ram.

I will check it later and let you know if there are any issues, but I'm sure it will be fine.

Cheers Dennis

On Wed, 17 Jan 2024 at 04:56, Ram Parameswaran @.***> wrote:

Closed #23 https://github.com/RamParameswaran/pyAFL/issues/23 as completed.

— Reply to this email directly, view it on GitHub https://github.com/RamParameswaran/pyAFL/issues/23#event-11502434533, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFL4LJFUUCKNNCWL2YWTJ2TYO3A4TAVCNFSM6AAAAABB4HNIUOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUYDENBTGQ2TGMY . You are receiving this because you were mentioned.Message ID: @.***>

RamParameswaran commented 9 months ago

Hey Dennis. Hmm have you tried specifying the version number? See this link https://towardsdatascience.com/pip-install-specific-version-how-to-install-a-specific-python-package-version-with-pip-1f97e1002f31

If that doesn't work, it should at least give an error message why it failed. Let me know how it goes.