RamakrushnaBiswal / PlayCafe

it a cafe website🚀
https://play-cafe.vercel.app/
MIT License
46 stars 106 forks source link

Feat: Add github pre-commit hool to prevent eslint warnings #291

Open lade6501 opened 1 month ago

lade6501 commented 1 month ago

Describe the feature

In current scenario devs are able to commit their changes even if eslint warnings are present. By adding a pre-commit hook for eslint devs will only be able to commit there changes when all eslint warnings are addressed. This will enhance code quality and readability of code.

Add ScreenShots

$ git commit

✔ Preparing lint-staged...
❯ Running tasks for staged files...
  ❯ packages/frontend/.lintstagedrc.json — 1 file
    ↓ *.js — no files [SKIPPED]
    ❯ *.{json,md} — 1 file
      ⠹ prettier --write
  ↓ packages/backend/.lintstagedrc.json — 2 files
    ❯ *.js — 2 files
      ⠼ eslint --fix
    ↓ *.{json,md} — no files [SKIPPED]
◼ Applying modifications from tasks...
◼ Cleaning up temporary files...

Record

github-actions[bot] commented 1 month ago

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project. for more information join our discord https://discord.gg/Jh3bWQ7FRN

RamakrushnaBiswal commented 1 month ago

good idea @lade6501 assigned