RamaneekGill / Twitter-Sentiment-Analysis

Contains machine learning methods on predicting sentiments for tweets.
GNU General Public License v3.0
12 stars 5 forks source link

Incorrect implementation of LDA (Latent Dirichlet Allocation) #3

Closed CyxouD closed 6 years ago

CyxouD commented 6 years ago

You stated that LDA (Latent Dirichlet Allocation) algorithm is used, but actually LinearDiscriminantAnalysis class is not implementation of this algorithm. LatentDirichletAllocation should be used. Correct me if I am wrong if those implementations are both for the same algorithm, but description of them, particularly at sklearn docs, don't look like this

RamaneekGill commented 6 years ago

You're right! I must have mixed up my acronyms along the way...