Ramaze / ramaze

Ramaze is a simple, light and modular open-source web application framework written in Ruby.
http://ramaze.net
371 stars 37 forks source link

Two failing tests in 2012.12.08 #67

Open rekado opened 11 years ago

rekado commented 11 years ago

There are two failing tests in Ramaze 2012.12.08:

1) spec/ramaze/log/syslog.rb

Syslog should escape % sequences [FAILED]

Bacon::Error: "ramaze_syslog_test[1802]: Hello Cruel |\xC3\xA9vil| \xE6\x88\x88 REAL %s World\n".==("ramaze_syslog_test[1802]: Hello Cruel |\u00E9vil| \u6208 REAL %s World\n") failed

2) spec/ramaze/dispatcher/directory.rb

Directory listing should dry serve root directory [FAILED]

Bacon::Error: [["../", "Parent Directory"], ["favicon.ico", "favicon.ico"], ["file+name.txt", "file name.txt"], ["test/", "test/"], ["test_download.css", "test_download.css"]].==([["../", "Parent Directory"], ["/favicon.ico", "favicon.ico"], ["/file+name.txt", "file name.txt"], ["/test/", "test/"], ["/test_download.css", "test_download.css"]]) failed
leucos commented 11 years ago

1) sounds like a locale problem. I have this with LC_ALL=en_US, but not with LC_ALL=en_US.utf8 2) I can not reproduce. Does it still fail ?

For one may be we should skip the test if the locale is not utf8 ? Or provide other possible outputs (like above) depending on the locale setting ?

leucos commented 11 years ago

I don't thinks this is an issue really. @manveru , we can check Locale.current.to_s =~ /UTF-8/ to skip the test or just close the issue.