Closed jihaekor closed 1 year ago
Thank you very much for this @jihaekor! 💛
I wonder why the tests aren't running on here - could it be that I must push? It could be some old api keys or something.
Eitherway, will run it later today and merge and release if all good!
Looks like it should run...
@Rambatino I think that was because I had the CircleCI running on my private forked repository - sorry about that. I unfollowed on my side and pushed up an update to the README (to add some blurbs about the optional package installations) to force the tests to fire.
Patch coverage: 96.87%
and project coverage change: +0.21%
:tada:
Comparison is base (
c773a87
) 92.90% compared to head (3e6568d
) 93.11%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I had a need to fit CHAID trees, and I had to update a few minor places in the code to get it to work with the latest packages (namely,
numpy
). This PR makes those updates and also pushes some of the package dependencies to be optional to reduce the size of the installation.np.float
andnp.int
. Updated each tonp.float64
andnp.int64
.split_groups
property in theSplit
class, which just returns thegroupings
as an actual list rather than the string representation of it.graph
(needed for generation of graphs, which isn't a core functionality needed to build the trees, per se) andspss
(only needed for the initial import)