search

Rambatino / CHAID

A python implementation of the common CHAID algorithm
Apache License 2.0
149 stars 50 forks source link

Use an explicit sentinel value rather than relying on integer cast of np.nan #138

Closed jihaekor closed 10 months ago

jihaekor commented 10 months ago

This fixes issue https://github.com/Rambatino/CHAID/issues/137.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a156be8) 93.29% compared to head (7dca4ee) 93.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #138 +/- ## ======================================= Coverage 93.29% 93.29% ======================================= Files 8 8 Lines 671 671 ======================================= Hits 626 626 Misses 45 45 ``` | [Files Changed](https://app.codecov.io/gh/Rambatino/CHAID/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Ramotowski) | Coverage Δ | | |---|---|---| | [CHAID/column.py](https://app.codecov.io/gh/Rambatino/CHAID/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mark+Ramotowski#diff-Q0hBSUQvY29sdW1uLnB5) | `91.22% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Rambatino commented 10 months ago

Looks good to me @jihaekor.

Given @xulaus's comment in the issue I'll merge now.

Rambatino commented 10 months ago

https://pypi.org/manage/project/CHAID/release/5.4.1/

Rambatino commented 10 months ago

Really appreciate the effort @jihaekor!