Added min_child_node_sixe for both weighted and unweighted case

Rambatino / CHAID

A python implementation of the common CHAID algorithm

Apache License 2.0

150 stars 50 forks source link

Added min_child_node_sixe for both weighted and unweighted case #43

Closed Rambatino closed 7 years ago

Rambatino commented 7 years ago

@xulaus which bit? The bit I rebased on top (which is the refactor) or the min base size stuff? Does it need much more testing?

xulaus commented 7 years ago

The refactor stuff has only been tested by me, as its such a substantial change it should have a lot of data ran over it to be 100% sure its working as it should.

Rambatino commented 7 years ago

Okay cool!

xulaus commented 7 years ago

I also know there is at least one bug on the ordinal variable branch, which I think was introduced later, but you know - need to be sure.