search

Rambatino / CHAID

A python implementation of the common CHAID algorithm
Apache License 2.0
150 stars 50 forks source link

Creating tree different from README #65

Closed asram6 closed 7 years ago

asram6 commented 7 years ago

Hi,

I am running the example for creating a CHAID tree in the README. When I get to the line tree.print_tree(), I get: ([], {1: 5, 2: 5}, ). This is different from the result in the README, so I was confused why this is happening. Also, could you give an overview of what the attributes are in the Tree object so I can better understand the output?

Thanks!

sriramab commented 7 years ago

Yes, I also have a different result. I mean, I have the same result as the above comment

tree.print_tree()
([], {1: 5, 2: 5}, <Invalid Chaid Split>)
Rambatino commented 7 years ago

Hi, let me review the README and get back to you. thanks!

Rambatino commented 7 years ago

Okay, so between v3.0.0 -> v.4.0.0 we changed the default for min_child_node_size. It was set at 0, but then we made it in line with min_parent_node_size, and thus changed it to 30.

I've updated the README, thanks!

Rambatino commented 7 years ago

Will have a think about a way to write up the different classes of the Tree, so they can be better understood. May have a look this weekend.