Rambatino / CHAID

A python implementation of the common CHAID algorithm
Apache License 2.0
150 stars 50 forks source link

Changed architecture of from_pandas_df to align variable types and instance variables into a single parameter #70

Closed Rambatino closed 7 years ago

Rambatino commented 7 years ago

fixes #53

xulaus commented 7 years ago

Although more tests would be nice

codecov[bot] commented 7 years ago

Codecov Report

Merging #70 into master will increase coverage by 1.79%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #70     +/-   ##
========================================
+ Coverage    90.8%   92.6%   +1.8%     
========================================
  Files           7       7             
  Lines         500     500             
========================================
+ Hits          454     463      +9     
+ Misses         46      37      -9
Impacted Files Coverage Δ
CHAID/invalid_split_reason.py 100% <100%> (ø) :arrow_up:
CHAID/tree.py 90.09% <100%> (+6.01%) :arrow_up:
CHAID/column.py 88.65% <0%> (+1.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fc4a40...213f2fc. Read the comment docs.