Ramble01 / nativedriver

Automatically exported from code.google.com/p/nativedriver
Apache License 2.0
0 stars 0 forks source link

Implement FindsByClassName #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
Implement FindsByClassName

When reviewing my code changes, please focus on:
r46+r47:
client.ClassNames
http://code.google.com/p/nativedriver/source/browse/branches/findbyclass/android
/src/com/google/android/testing/nativedriver/client/ClassNames.java?spec=svn47&r
=47

server.AndroidNativeElement
http://code.google.com/p/nativedriver/source/browse/branches/findbyclass/android
/src/com/google/android/testing/nativedriver/server/AndroidNativeElement.java?r=
46

server.ElementFInder
http://code.google.com/p/nativedriver/source/browse/branches/findbyclass/android
/src/com/google/android/testing/nativedriver/server/ElementFinder.java?r=46

server.ViewElement
http://code.google.com/p/nativedriver/source/browse/branches/findbyclass/android
/src/com/google/android/testing/nativedriver/server/ViewElement.java?spec=svn46&
r=46

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by matv...@google.com on 27 Jun 2011 at 1:40

GoogleCodeExporter commented 9 years ago
Assigning to tkaizu@
I would like dxu@ to do the review as well.

Original comment by matv...@google.com on 27 Jun 2011 at 1:42

GoogleCodeExporter commented 9 years ago
LGTM. I have no comment.

Original comment by tka...@google.com on 27 Jun 2011 at 2:37

GoogleCodeExporter commented 9 years ago
LGTM

Original comment by d...@google.com on 29 Jun 2011 at 5:31