RamblingCookieMonster / BuildHelpers

Helper functions for PowerShell CI/CD scenarios
MIT License
216 stars 47 forks source link

Get-ProjectName fails when alias `git` exists #136

Open peetrike opened 2 years ago

peetrike commented 2 years ago

When there is defined alias with name git, the Get-ProjectName command (called without parameters) emits following error message:

The variable cannot be validated because the value $null is not a valid value for the GitPath variable.
At C:\Program Files\WindowsPowerShell\Modules\BuildHelpers\2.0.16\Public\Get-ProjectName.ps1:57 char:9
+         $GitPath = (Get-Command $GitPath -ErrorAction SilentlyContinu ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The command itself works despite the error above.

The error could be avoided when $GitPath variable contains string git.exe or when the get-command has parameter -CommandType Application added at: https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Get-ProjectName.ps1#L57

peetrike commented 2 years ago

Also the next line could have parameter -CommandType Application added: https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Get-ProjectName.ps1#L47

peetrike commented 2 years ago

The same problematic pattern is also in Invoke-Git command: https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Invoke-Git.ps1#L87