search

RamblingCookieMonster / PSDepend

PowerShell Dependency Handler
MIT License
285 stars 76 forks source link

DependencyTypes for runtimes like dotnetcore? #39

Open WernerMairl opened 7 years ago

WernerMairl commented 7 years ago

Hi i like the idea behind this project. What about creating dependencytypes for Tools/Environments like NodeJS or Dotnetcore ?

any concerns that this does not fits into the project goals ? any plans in this direction ?

regards Werner

RamblingCookieMonster commented 7 years ago

Hiyo!

Seems reasonable. I would assume those ecosystems have nicer dependency handlers, but if it would help to have them in psdepend, and you're up for writing them (this doesn't use classes, so code will be ugly!), I'd totally take a pull request : )

Cheers!

michaeltlombardi commented 7 years ago

Hey, so one of my modules actually requires some node modules for its work. Looking to tackle this shortly.

From a design of PSDeploy perspective, it looks like for any given type (the example I looked up was git), we are okay assuming that the user has already installed the executable. So when working on this, it'd be okay to throw an error if npm can't be found in the path? The alternative is to try to resolve and install node/npm, which seems like a bit of a mess.

RamblingCookieMonster commented 7 years ago

Awesome!

Yeah, as long as you note the requirement in the docs and have a friendly message, I think it makes sense to simply let the user handle it.

For nuget we have a bootstrap script that we use - I can see that for cases where something is:

Git didn't meet this criteria, so we just depend on it

Cheers!

michaeltlombardi commented 7 years ago

Well, once we get a choco dependency type in place, we can just rely on that for git/node/go/etc. 😉

michaeltlombardi commented 7 years ago

I do have some code done on this, planning on making more headway tonight after work.

michaeltlombardi commented 7 years ago

I've got some WIP in place for node modules in #40. 👷

michaeltlombardi commented 7 years ago

@WernerMairl, does the NPM support added in #40 work for you? I haven't poked at DotNet Core yet, but NPM should "just" work, as long as you have node installed.

RamblingCookieMonster commented 6 years ago

Changing the title given that NPM has been implemented - thanks again @michaeltlombardi!

michaeltlombardi commented 6 years ago

No problem!