WIP: Initial support for node modules

RamblingCookieMonster / PSDepend

PowerShell Dependency Handler

MIT License

285 stars 76 forks source link

Closed michaeltlombardi closed 7 years ago

michaeltlombardi commented 7 years ago

Allows users to specify node modules and install via NPM.
Initial work only allows users to install modules by name and version (default to latest).
Includes private functions for getting node modules and installing them.
Allows users to save globally, to the current directory, or to a specified path.
Includes unit tests.

michaeltlombardi commented 7 years ago

@RamblingCookieMonster, this PR should be ready for review now. :)

Sorry this took so long!

RamblingCookieMonster commented 7 years ago

Awesome!

Two nitpicks (don't think we need to address before merge):

I think we can remove $Force param for npm.ps1
A few spots where it might be worth doing $null comparison with $null on left (not sure if it will even matter here)

Looks good to me! Will give it a quick manual test, wait a day or so for any other input, and merge this in : ) thanks!

Edit: awesome, played around with it, working without issue!

michaeltlombardi commented 7 years ago

Ach, sorry, I just saw your feedback! I'll work on fixing both of those and submit a new PR with the fixes. :)