search

RamblingCookieMonster / PSDepend

PowerShell Dependency Handler
MIT License
285 stars 76 forks source link

Parameter 'SkipPublisherCheck' cannot be found #63

Closed dargmuesli closed 6 years ago

dargmuesli commented 6 years ago

Recently, support for the Install-Module cmdlet's parameter -SkipPublisherCheck was added (a43278eef11c5e29a4149edc920f96139620e3ac). Since then my AppVeyor builds failed with the following error message:

A parameter cannot be found that matches parameter name 'SkipPublisherCheck'.

AppVeyor seems to be using an older version of PowerShell that doesn't support this parameter yet. I've opened an issue in their repository to update their version and pushed a ... temporary workaround to my repo that just pins PSDepend's version to one of the last working: Install-Module -Name "PSDepend" -RequiredVersion "0.1.56" ... fix that set the image directive in my appveyor.yml to:

image: Visual Studio 2017

This made appveyor use the most current PowerShell version (5.1.14393.1715 at the moment).

I just want to leave this note here in case anyone else has this issue too.

dargmuesli commented 6 years ago

Reopening, because another option came to my mind. What about implementing a version check in PSDepend? We would need to find out what version SkipPublisherCheck was added to Install-Module and remove it from @params if not satisfied. Any thoughts on problems that would prevent this implementation? Maybe we can also add an option to override the version check. Can there be the case that PowerShell has a version that makes it look like it doesn't support the parameter, but if fact it does, because one can update the cmdlet itself somehow? Just asking before someone puts effort into this.

RamblingCookieMonster commented 6 years ago

Makes sense to me, conditionally allow that parameter depending on PowerShellGet version (I'm assuming that's how we could determine this)?

RamblingCookieMonster commented 6 years ago

closing, thanks for the pr!