RamblingCookieMonster / PSDepend

PowerShell Dependency Handler
MIT License
285 stars 76 forks source link

dotnet sdk as DependencyType #92

Closed TylerLeonhardt closed 6 years ago

TylerLeonhardt commented 6 years ago

As the name implies, this allows you to specify the .NET SDK version you want.

Here are a couple different configs that work:

@{
    'DotnetSdk::release' = '2.1.401'
}
@{
    release = @{
        DependencyType = 'DotnetSdk'
        Version = '2.1.401'
        Target = './.dotnet/'
    }
}

Out of scope possibly: querying for the latest version of the .NET SDK (see the TODO in the code)

Note: This ensures you have a minimum version of the .NET SDK. Not the specific version.

cc'ing interested parties: @RamblingCookieMonster @SeeminglyScience

Fixes https://github.com/RamblingCookieMonster/PSDepend/issues/90

TylerLeonhardt commented 6 years ago

Alright! Tests and comments! It's ready for review 👍

@RamblingCookieMonster @SeeminglyScience

RamblingCookieMonster commented 6 years ago

Yay : D lgtm on a first pass - @SeeminglyScience any chance you'd be up for taking a look as well?

Cheers!

TylerLeonhardt commented 6 years ago

🚥 green lights ✅ your move @SeeminglyScience + @RamblingCookieMonster 😎

RamblingCookieMonster commented 6 years ago

Yayyy! Thanks again @tylerl0706, @SeeminglyScience !!

TylerLeonhardt commented 6 years ago

When are you planning on doing a release @RamblingCookieMonster just so I know when I can start using it for real 😊

RamblingCookieMonster commented 6 years ago

Oh! I'm somewhat cavalier with releases : )

I'll have to bump to 3.0.1 or something and toss in release notes, will poke around issues to see if I can tackle any low hanging fruit along the way

Cheers!!

TylerLeonhardt commented 6 years ago

Nice! That'd be awesome - this project is great 👍

I see it as an awesome tool for managing hybrid (C# + PowerShell) based project dependencies 😊