search

RamblingCookieMonster / PSRabbitMq

PowerShell module to send and receive messages from a RabbitMq server
http://ramblingcookiemonster.github.io/RabbitMQ-Intro/
MIT License
47 stars 29 forks source link

Register-RabbitMqEvent: adding parameter vhost to the powershell job #31

Closed th0sxph closed 4 years ago

th0sxph commented 4 years ago

Description

Added vhost to the argument list and to the job parameter list.

Motivation and Context

Since the powershell jobs run in a different scope, vhost was always null since it was not part of the job parameter list, despite the vhost parameter being exposed on the Register-RabbitMqEvent command.

RamblingCookieMonster commented 4 years ago

Makes sense to me, thanks!

yuvalmarciano commented 4 years ago

Makes sense to me, thanks!

Hi Warren, could you review my PR as well please? https://github.com/RamblingCookieMonster/PSRabbitMq/pull/29

RamblingCookieMonster commented 4 years ago

who knows how old this build setup is... might not publish...

@yuvalmarciano - if it's simple like this one sure, taking a look

th0sxph commented 4 years ago

Makes sense to me, thanks!

You're welcome!

th0sxph commented 4 years ago

who knows how old this build setup is... might not publish...

https://www.powershellgallery.com/packages/PSRabbitMq/0.3.2/Content/Register-RabbitMqEvent.ps1

:shipit: Published with success.