RamblingCookieMonster / RabbitMQTools

PowerShell module containing cmdlets to manage RabbitMQ.
http://ramblingcookiemonster.github.io/RabbitMQ-Intro/
MIT License
31 stars 22 forks source link

VirtualHost parameter inconsistently defined #1

Closed gpduck closed 9 years ago

gpduck commented 9 years ago

The following functions have the VirtualHost parameter set to mandatory and do not provide a default value:

The following functions have the VirtualHost parameter set to mandatory (but do provide a default value):

I feel like optional with default value is the way to go for all of them, but wanted to get feedback before I submit a PR.

RamblingCookieMonster commented 9 years ago

Agreed, makes sense to me!

Looking for $defaultVirtualHost, I only see it defined in constants.ps1, which is only called in the tests. Might switch these over to hard coded '/', or setting up a module config of sorts. A variable seems difficult to discover.

gpduck commented 9 years ago

Isn't it called in the psm1?

I'm going to update the parameters to use the variable, and later if we add persistent settings that process will just need to update the variable.