Closed hatfieldbrian closed 2 years ago
This addresses Bill Stoddard's concern:
How to fence this in properly so we don’t get hit with critsit support tickets for Tech/Dev preview code
I suggest it be a Ramen operator configmap boolean or string/enum and have a disabled value by default.
Currently Ramen checks the kube object protection spec in 3 places:
The operator-level protection indicator should also be checked in these 3 places, perhaps in a function...
If either this new operator-level switch is "disabled" or the kube object protection spec pointer is nil, the don't do the shioramen bits
For MVP, unprotection (i.e. state enabled -> disabled state transition) need not be clean....some stuff may be left around.
Fixed by #59
hatfieldbrian
commented
2 years ago hatfieldbrian
commented
2 years ago
This addresses Bill Stoddard's concern:
I suggest it be a Ramen operator configmap boolean or string/enum and have a disabled value by default.
Currently Ramen checks the kube object protection spec in 3 places:
The operator-level protection indicator should also be checked in these 3 places, perhaps in a function...
If either this new operator-level switch is "disabled" or the kube object protection spec pointer is nil, the don't do the shioramen bits
For MVP, unprotection (i.e. state enabled -> disabled state transition) need not be clean....some stuff may be left around.