Closed ShyamsundarR closed 3 months ago
TODO:
@BenamarMk and @raghavendra-talur code is complete for review, will be doing e2e tests tomorrow.
@BenamarMk e2e against Volsync and volrep completed (series of deploy->failover->relocate->failover like scenarios), no issues found with the changes.
Check if a VRG either exists as Primary on the failoverCluster or if Secondary protectes PVCs via VolSync, in all other cases Secondary cluster is not ready for a failover.
e.g a hub loss and a managed cluster loss when the surviving cluster was the Secondary may not be a peer ready cluster to failover to.
Additionally: Check if VRG has reached Primary state before cleanup
In cases where switchToCluster loops out due to errors or due to waiting for VRG to manifest on the failoverCluster, the core failover loop does not additionally check is VRG has reached the Primary state.
This commit addresses this gap.
NOTE: In such cases placement decision is also potentially not updated but that is ensured before entering cleanup phase in ensureActionCompleted