RamenDR / ramen

Apache License 2.0
72 stars 52 forks source link

Upgrade minikube to 1.33.0 #1375

Closed nirs closed 3 months ago

nirs commented 3 months ago

Minikube 1.33.0 adds useful features, fixes, and performance improvements, but we could not use it because of a regression in systemd-resolved[1].

A critical change in 1.33.0 is upgrading the kernel to 5.10.207. This version fixes bad bug with minikube 1.32.0, when qemu assertion fails while starting a kubevirt VM[2] on newer Intel CPUs (i7-12700k).

This change:

drenv configuration includes:

With the new configuration we can upgrade to minikube 1.33.0, and Alex can run drenv kubevirt environment without manual hacks.

When the configuration changes are released in minikube, we can remove the code in drenv.minikube, but I would keep the infrastructure for adding and loading configuration so in the next time we have an issue we will have easy way fix.

[1] https://github.com/kubernetes/minikube/issues/18705 [2] https://gitlab.com/qemu-project/qemu/-/issues/237

nirs commented 3 months ago

@akalenyu do you want to review this?