search

RamenDR / ramen

Apache License 2.0
72 stars 52 forks source link

Remove flannel cni from kubevirt envs #1380

Closed nirs closed 3 months ago

nirs commented 3 months ago

This was added based on kubevirt minikube quick start guide[1], but it seems to be outdated. Minikube default cni works fine for both kubevirt.yaml and regional-dr-kubevirt.yaml.

[1] https://kubevirt.io/quickstart_minikube/

akalenyu commented 3 months ago

/lgtm

makes total sense to me from the kubevirt side. looks like this CNI was needed for masquerade which anyway isn't working. masquerade may be required at some point for migration though, but we will cross that bridge when we get to it: https://kubevirt.io/user-guide/virtual_machines/interfaces_and_networks/#passt This has the live migration support matrix.