search

RamenDR / ramen

Apache License 2.0
70 stars 51 forks source link

Create ramenOpsNamespace such that it is not cleaned up when ramen operator is uninstalled #1393

Open raghavendra-talur opened 2 months ago

raghavendra-talur commented 2 months ago

In #1366 we added the functionality to automatically create the ramenOpsNamespace on the hub and the managed clusters. However, it is done using manifestwork for the managedclusters thereby removing the ramenops namespace when the operator is uninstalled.

Ideally, we want to keep the ramenOpsNamespace intact even after the operator is uninstalled.

raghavendra-talur commented 2 months ago

Looks like setting a deleteOption of orphan is possible with the latest OCM manifest work api but it is not available in the version of stolostron fork we use. Refer to https://github.com/open-cluster-management-io/api/blob/main/work/v1/types.go#L43 and https://open-cluster-management.io/concepts/manifestwork/#delete-options

ShyamsundarR commented 2 months ago

Looks like setting a deleteOption of orphan is possible with the latest OCM manifest work api but it is not available in the version of stolostron fork we use. Refer to https://github.com/open-cluster-management-io/api/blob/main/work/v1/types.go#L43 and https://open-cluster-management.io/concepts/manifestwork/#delete-options

This is being fixed here: https://github.com/RamenDR/ramen/pull/1381/commits/0f2df3e0af78fb1a7097420bf616c9e1a7bcab63