search

RamenDR / ramen

Apache License 2.0
70 stars 51 forks source link

Move to controller-sdk 1.34.2 #1412

Closed ShyamsundarR closed 2 weeks ago

ShyamsundarR commented 1 month ago

The move to operator-sdk is to aid with newer APIs that we may define and overall catching up to the later sdk versions for maintainability of the code base in the future.

This commit has 2 major changes as follows,

The above hence entails changes to Makefile, import paths, and other artifacts that are path dependent.

The above changes patchesStrategicMerge to patches and commonLabels to labels (though the latter is unused in comments)

Related to the actual change is to move the PROJECT file to kubebuilder v4 and to update the install scripts to use the latest versions of the required tools.

Overall changes were performed following the upgrade guides from v1.24.0 to v1.34.2: https://sdk.operatorframework.io/docs/upgrading-sdk-version/

One of the bigger change to move from kubebuilder v3 to v4 required following the migration guide at: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

Open areas: Move to gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0 Change transformers to labels in kustomize

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com

nirs commented 1 month ago

@ShyamsundarR do you think this will solve the issue with olm 0.27?

ShyamsundarR commented 1 month ago

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

ShyamsundarR commented 1 month ago

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

OR... let me check the delta again to see any olm related changes.

ShyamsundarR commented 1 month ago

@ShyamsundarR do you think this will solve the issue with olm 0.27?

No :( This is so that newer APIs that we define, we can be on the latest operator-sdk and also on later dependencies as such (including kustomize).

OR... let me check the delta again to see any olm related changes.

There is/was nothing in the upgrade notes regarding the bundle as such, the operator-sdk version is changed and may help with the bundle+olm version issue that we have, but not certain.