search

RamenDR / ramen

Apache License 2.0
70 stars 51 forks source link

Delete NF manifest work after unfence #1417

Closed ELENAGER closed 1 month ago

ELENAGER commented 1 month ago

There were 2 separate problems:

  1. The name of the NF MW was wrong - we used drcluster namespace, which is empty, instead of peer cluster name
  2. We were execting function DeleteManifestWork to return "not found" error, which never happens, in order to finish the cleaning process.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2246638

ELENAGER commented 1 month ago

@nirs the deleted code was never invoked.

nirs commented 1 month ago

@ELENAGER thanks, this makes sense now, so the only thing missing is proper commit message explaining the changes.

ELENAGER commented 1 month ago

@nirs the 3 commit messages are: Author: Elena Gershkovich elenage@il.ibm.com Date: Thu May 23 16:13:54 2024 +0530

**Adjust tests for deletion of NF MW after unfence**

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>

commit f3f79e03de21aa3b47a5aa773093d66bfdaff8c5 Author: Elena Gershkovich elenage@il.ibm.com Date: Wed May 22 15:39:00 2024 +0300

**DeleteManifestWork returns nil when MW was not found**

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>

commit bd93b3d4fd5ee38a51a4e9c21c86d3f3a4955ce5 Author: Elena Gershkovich elenage@il.ibm.com Date: Tue May 21 19:04:13 2024 +0300

**Use peer cluster name as namespace in NF manifest name**

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>

Which one do you suggest to change and how?