RamenDR / ramen

Apache License 2.0
70 stars 51 forks source link

Update Protected condition to report true for Sync DR cases #1430

Closed ShyamsundarR closed 1 month ago

ShyamsundarR commented 1 month ago

When DataProtected is false with reason Replicating for Sync DR we still report Protected as false. This is corrected with this commit.

In the Sync DR case we update DataProtected with reason VRGConditionReasonReady but, the actual update to the condition in setPVCDataProtectedCondition overrides this back to reason Replicating, with status as false.

While the above seems counterintuitive the fix is to address the Protected condition for sync DR, as otherwise constant alerts regarding the protection status is fired, due to it remaining false always.

The condition DataProtected is not corrected to true, which needs to be tracked and ensured for its correctness.