Closed youhangwang closed 1 month ago
@youhangwang I completed the review of the source part. Overall, looks good to me. I didn't want to overwhelm the PR with nit
comments for now. What is left is the destination part, which is more complicated. Then, I'll try to run it locally.
jFYI added a tracker issue for any pending items that would not be addressed in this PR w.r.t CG support in Ramen, https://github.com/RamenDR/ramen/issues/1501
Manual tested the following use cases:
The CG-related code has been tested, and the happy path works in drenv
. Some missing elements will be added to the tracker. We will merge it as is. The VolSync consistency group code will NOT execute unless the annotation ramendr.openshift.io/consistency-group
is set in DRPC, which eventually propagates to the VRG.
move pr https://github.com/RamenDR/ramen/pull/1401 to this one as the main branch have changed a lot due to upgrade kubebuilder