add cg controllers for cephfs

RamenDR / ramen

Apache License 2.0

72 stars 52 forks source link

add cg controllers for cephfs #1484

Closed youhangwang closed 1 month ago

youhangwang commented 1 month ago

move pr https://github.com/RamenDR/ramen/pull/1401 to this one as the main branch have changed a lot due to upgrade kubebuilder

BenamarMk commented 1 month ago

@youhangwang I completed the review of the source part. Overall, looks good to me. I didn't want to overwhelm the PR with nit comments for now. What is left is the destination part, which is more complicated. Then, I'll try to run it locally.

ShyamsundarR commented 1 month ago

jFYI added a tracker issue for any pending items that would not be addressed in this PR w.r.t CG support in Ramen, https://github.com/RamenDR/ramen/issues/1501

youhangwang commented 1 month ago

Manual tested the following use cases:

[x] NO VolumeGroupSnapshot CRD, NO ReplicationGroupSource Created
[x] NO VolumeGroupSnapshot CRD, ReplicationGroupSource Created
[x] Volsync Disabled
[x] Volsync Enabled
[x] CG Disabled
[x] CG Enabled

BenamarMk commented 1 month ago

The CG-related code has been tested, and the happy path works in drenv. Some missing elements will be added to the tracker. We will merge it as is. The VolSync consistency group code will NOT execute unless the annotation ramendr.openshift.io/consistency-group is set in DRPC, which eventually propagates to the VRG.