search

RamenDR / ramen

Apache License 2.0
72 stars 52 forks source link

Switch from using Sets from k8s.io/apimachinery/pkg/util/sets as it is deprecated #1486

Open ShyamsundarR opened 1 month ago

ShyamsundarR commented 1 month ago

Potentially using slices.Contains instead of sets in these instances.

nirs commented 1 month ago

@ShyamsundarR where do you see that the package is deprecated?

The typed sets are: https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets#String

But the generic set is not: https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets#Set

ShyamsundarR commented 1 month ago

Correct, typed sets are and not generic ones, and requires a switch to the generic ones in code where used.