search

RamenDR / ramen

Apache License 2.0
74 stars 56 forks source link

go.mod: argocd and gitops dependencies are removed while upgrading to csi-addons to v.0.7.0 #958

Open rakeshgm opened 1 year ago

rakeshgm commented 1 year ago 
-> go get -u github.com/csi-addons/kubernetes-csi-addons@latest
go: upgraded cloud.google.com/go/compute v1.15.1 => v1.19.1
go: removed github.com/argoproj/argo-cd/v2 v2.7.0-rc2
go: removed github.com/argoproj/gitops-engine v0.7.1-0.20230214165351-ed70eac8b7bd
go: upgraded github.com/csi-addons/kubernetes-csi-addons v0.6.0 => v0.7.0
go: upgraded github.com/csi-addons/spec v0.2.0 => v0.2.1-0.20230606140122-d20966d2e444
go: upgraded github.com/go-logr/logr v1.2.3 => v1.2.4
go: upgraded github.com/go-logr/zapr v1.2.3 => v1.2.4
go: upgraded github.com/moby/term v0.0.0-20220808134915-39b0c02b01ae => v0.0.0-20221205130635-1aeaba878587
go: upgraded github.com/onsi/ginkgo/v2 v2.9.2 => v2.9.7
go: upgraded github.com/onsi/gomega v1.27.4 => v1.27.8
go: upgraded github.com/prometheus/client_golang v1.14.0 => v1.15.1
go: upgraded github.com/prometheus/client_model v0.3.0 => v0.4.0
go: upgraded github.com/prometheus/common v0.39.0 => v0.42.0
go: upgraded github.com/rogpeppe/go-internal v1.8.0 => v1.10.0
go: upgraded golang.org/x/mod v0.9.0 => v0.10.0
go: upgraded golang.org/x/net v0.8.0 => v0.10.0
go: upgraded golang.org/x/oauth2 v0.4.0 => v0.7.0
go: upgraded golang.org/x/sync v0.1.0 => v0.2.0
go: upgraded golang.org/x/sys v0.6.0 => v0.8.0
go: upgraded golang.org/x/term v0.6.0 => v0.8.0
go: upgraded golang.org/x/text v0.8.0 => v0.9.0
go: upgraded golang.org/x/tools v0.7.0 => v0.9.1
go: upgraded gomodules.xyz/jsonpatch/v2 v2.2.0 => v2.3.0
go: upgraded google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f => v0.0.0-20230410155749-daa745c078e1
go: upgraded google.golang.org/grpc v1.53.0 => v1.56.1
go: upgraded google.golang.org/protobuf v1.28.1 => v1.31.0
go: upgraded k8s.io/api v0.26.2 => v0.27.3
go: upgraded k8s.io/apiextensions-apiserver v0.26.1 => v0.27.2
go: upgraded k8s.io/apimachinery v0.26.2 => v0.27.3
go: upgraded k8s.io/apiserver v0.26.1 => v0.27.2
go: upgraded k8s.io/component-base v0.26.1 => v0.27.2
go: upgraded k8s.io/klog/v2 v2.90.1 => v2.100.1
go: upgraded k8s.io/kube-openapi v0.0.0-20230123231816-1cb3ae25d79a => v0.0.0-20230501164219-8b0f38b5fd1f
go: downgraded k8s.io/kubernetes v1.26.1 => v1.15.0-alpha.0
go: upgraded k8s.io/utils v0.0.0-20230115233650-391b47cb4029 => v0.0.0-20230220204549-a5ecb0141aa5
go: upgraded sigs.k8s.io/controller-runtime v0.14.5 => v0.15.0

in the above, we see that github.com/argoproj/argo-cd/v2 v2.7.0-rc2 and github.com/argoproj/argo-cd/v2 v2.7.0-rc2 are removed which are needed by ramen.

rakeshgm commented 1 year ago

do we add them under replace section in go.mod

raghavendra-talur commented 1 year ago

Using a go get command forces a check of the imports and because of the following import tree we have a failure of the check.

Ramen imports argoproj/argo-cd argoproj/argo-cd imports gitops-engine gitops-engine imports k8s.io/kubernetes.

It is documented in https://github.com/argoproj/argo-cd/issues/4055 and https://github.com/argoproj/argo-cd/issues/4055#issuecomment-801333695.

Kubernetes project discourages the import of k8s.io/kubernetes and recommends import of individual modules. While we wait for the argoproj to fix the dependencies, we can update the go.mod file manually and then run the go mod tidy command to skip these checks.

We already have the replace directives required for the modules.