RameshRaj / thrift-protobuf-compare

Automatically exported from code.google.com/p/thrift-protobuf-compare
0 stars 0 forks source link

XStreamSerializer.java error in registerConverters() #15

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There's a copy/paste error on line 80, Image.class should be Media.class:

public void registerConverters() throws Exception
  {
    xstream.alias("im", Image.class);
    xstream.registerConverter(new ImageConverter());

    xstream.alias("md", Image.class);    // This line in error.
    xstream.registerConverter(new MediaConverter());

    xstream.alias("mc", MediaContent.class);
    xstream.registerConverter(new MediaContentConverter());
  }

Original issue reported on code.google.com by jim.ferr...@gmail.com on 12 Dec 2009 at 3:04

GoogleCodeExporter commented 8 years ago
Weird, why doesn't this fail? I don't understand this serializer, but I would 
expect,
that BenchmarkRunner.checkCorrectness(.) should fail.

I fixed this locally, doesn't seem to change anything. Do you know why, by any 
chance?

Original comment by michael....@gmail.com on 6 Jan 2010 at 9:18

GoogleCodeExporter commented 8 years ago
Michael, I'm afraid I don't.  I've used XStream but haven't used a converter 
yet.  Sorry!

Original comment by jim.ferr...@gmail.com on 11 Jan 2010 at 5:24

GoogleCodeExporter commented 8 years ago
ok, I fixed the copy and paste bug in the repo. While it strangely doesn't seem 
to
have an effect, the mistake seems too obvious. 
Thanks for the report, Jim!

Original comment by michael....@gmail.com on 11 Jan 2010 at 8:52