search

Rami114 / pinboard

Firefox Quantum plugin
https://addons.mozilla.org/en-US/firefox/addon/pinboard-quantum/
16 stars 0 forks source link

Inverted color icon for dark themes #7

Open pawandubey opened 6 years ago

pawandubey commented 6 years ago

I have a dark theme for FireFox, and currently the icon in the address bar looks like this:

screenshot_20180116_194257

It would be great if you could include a gray-ish alternate icon with a setting to use the appropriate one according to the theme.

Rami114 commented 6 years ago

That's some terrible icon-ness going on. I stole these from the 'official' version, but yeah I'll do some dark-theme-friendly versions ASAP!

pawandubey commented 6 years ago

Awesome! Thanks!

I have no idea how much work it is but it would be great to use the firefox theme overall. For example, the dropdown for context menu looks like this:

screenshot_20180116_210635

Whereas for the dropdown for the icon, it looks like this:

screenshot_20180116_210739

Not at all a functionality issue - love the implementation - but it does look odd.

Rami114 commented 6 years ago

I think that one should be easy. The current drop-down has a hard-coded background colour but I just tested it without that explicit colour in place and it automatically used whatever FF had.

Could you let me know how you got the dark theme? It seems this is another type of Add-On and not a built-in feature? So I can test :)

pawandubey commented 6 years ago

Oh yes. I am using KDE Neon with the Arc theme. But you can get the theme just for Firefox from here: https://addons.mozilla.org/en-US/firefox/addon/arc-dark-theme/