Closed dependabot[bot] closed 1 month ago
@anthony2261 can we do this bump yet? Not sure if we can already solve the issues we were facing before. I forgot what that dependency issue was.
I'm asking cause it has a critical vulnerability addressed in python-multipart, would be nice to patch.
@RamiAwar We can do this if we drop the session: AsyncSession = Depends(get_session)
dependency on the query
endpoint (backend/dataline/api/conversation/router.py
) and instead create the session inside the conversation_service.query
method. This was the only issue we had that prevented us from upgrading (S.C. found this bug while trying it out 😞)
@RamiAwar We can do this if we drop the
session: AsyncSession = Depends(get_session)
dependency on thequery
endpoint (backend/dataline/api/conversation/router.py
) and instead create the session inside theconversation_service.query
method. This was the only issue we had that prevented us from upgrading (S.C. found this bug while trying it out 😞)
Okay I don't love that. Let's delay merging this as much as possible. The thread on FastAPI is not getting any attention yet. I frequently get updates from there of people just tagging Sebastian but no response yet.
@RamiAwar there's another breaking change that's even worse in that same version change: https://github.com/tiangolo/fastapi/issues/10857
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps fastapi from 0.105.0 to 0.109.1.
Release notes
Sourced from fastapi's releases.
... (truncated)
Commits
7633d15
🔖 Release version 0.109.1a4de147
📝 Update release notes9d34ad0
Merge pull request from GHSA-qf9m-vfgh-m389ebf9723
📝 Update release notes8590d0c
👥 Update FastAPI People (#11074)063d7ff
📝 Update release notes3c81e62
🌐 Add Spanish translation fordocs/es/docs/external-links.md
(#10933)6c4a143
📝 Update release notesd254e2f
🌐 Update Korean translation fordocs/ko/docs/tutorial/first-steps.md
, `docs...6f6e786
📝 Update release notesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show