RamiKrispin / TSstudio

Tools for time series analysis and forecasting

https://ramikrispin.github.io/TSstudio/

Other

421 stars 65 forks source link

horizon parameter doesn't work #48

Closed VitoFanelli closed 4 years ago

VitoFanelli commented 4 years ago

horizon parameter is ignored. Best model forecast missing. Maybe the problem is here

Creating grid of all the modeling combinations

grid_df <- base::expand.grid(models_df$model_id, s1, train_method$sample.out, stringsAsFactors = FALSE) %>% stats::setNames(c("model_id", "start", "horizon")) %>% ...

sample.out is overwrite with "horizon"?

RamiKrispin commented 4 years ago

Hi @VitoFanelli,

Could you please provide a reproducible example (how did you generate model_df object)? I am struggling to understand what is models_df object

RamiKrispin commented 4 years ago

The issue was on the train_model function - fixed and updated on version 0.1.6