Ramilito / kubectl.nvim

Apache License 2.0
165 stars 5 forks source link

feat: port forward mark and stop #122

Closed Ramilito closed 1 month ago

Ramilito commented 1 month ago

You can now use gP to list all active port-forwards and close them without affecting the underlying service

Solves #66

demo:

pf

mosheavni commented 1 month ago

just one note, the state of ports forwarded must be persistent across sessions, so in-memory is not good, need to save it to a file or dynamically check

Ramilito commented 1 month ago

just one note, the state of ports forwarded must be persistent across sessions, so in-memory is not good, need to save it to a file or dynamically check

Agreed! This implementation would be classified as a dynamic check since it's done on every redraw and does a lookup in the system (not memory) to check for any port-forwards, or did you mean something else?

mosheavni commented 1 month ago

just one note, the state of ports forwarded must be persistent across sessions, so in-memory is not good, need to save it to a file or dynamically check

Agreed! This implementation would be classified as a dynamic check since it's done on every redraw and does a lookup in the system (not memory) to check for any port-forwards, or did you mean something else?

no, you got it :)