Ramilito / kubectl.nvim

Apache License 2.0
158 stars 4 forks source link

question about "pending" and "running" state #73

Closed idelice closed 1 month ago

idelice commented 1 month ago

They have the same color.

Is that on purpose? If so, can i suggest a different color based on the state? Or is it out of this plugins' scope?

Screenshot 2024-07-02 at 19 05 26
Ramilito commented 1 month ago

That's a bug, must have happened when I switched how we highlight stuff, #65. It should be a straightforward fix, brb

Ramilito commented 1 month ago

hmmm...this is how it's looking for me:

image

Are you on latest? could you run this command: new | pu=execute('highlight') and locate the ones that are prefixed with "Kubectl", I'm mostly interested in KubectlWarning

It should look like this:

KubectlHeader  xxx guifg=#569cd6
KubectlWarning xxx guifg=#d19a66
KubectlError   xxx guifg=#d16969
KubectlInfo    xxx guifg=#608b4e
KubectlDebug   xxx guifg=#dcdcaa
KubectlSuccess xxx guifg=#4ec9b0
KubectlPending xxx guifg=#c586c0
KubectlDeprecated xxx guifg=#d4a5a5
KubectlExperimental xxx guifg=#ce9178
KubectlNote    xxx guifg=#9cdcfe
KubectlGray    xxx guifg=#666666
Ramilito commented 1 month ago

nvm I can recreate now, seems to happen whin filtering

Ramilito commented 1 month ago

The issue was related to the extmark issue in that we need to filter before setting extmarks, I think it should be fixed now!