Ramilito / kubesess

Kubectl plugin managing sessions
MIT License
205 stars 5 forks source link

[Fix] - Kubeconfig merge needs user and cluster #59

Open Ramilito opened 7 months ago

Ramilito commented 7 months ago

Description

When merging and not using kubeconfig env variable, the resulting cached files don't have cluster and user in them. This PR adds those so they can be more complete. Results: default

Fixes # (issue)

46 Fixes part of this

Type of change

How Has This Been Tested?

Tested locally by using it for a while

nicmr commented 7 months ago

Hi, thanks for adding me as a reviewer 😊 I'm quite busy this week but I'll have a look this Saturday!

Ramilito commented 6 months ago

Ive been running with this for a while and only noticed one issue, the kcd command doesn't permanently set it, I'm guessing it's because the merged files isn't known to kubectl. Will try setting the --kubeconfig command dynamically and see if it helps