RamonUnch / GreenPad

Fork from roytam1 fork from original GreenPad
22 stars 0 forks source link

Help -> About menu #73

Closed DotNetTester closed 1 year ago

DotNetTester commented 1 year ago

A minor suggestion. A help menu with an About submenu at the end of the main menu with a dialog that displays the version of GreenPad installed.

I'm used to seeing this in Notepad and it's noticeable that it's missing in GreenPad.

RamonUnch commented 1 year ago

it does miss in green pad for sure.

RamonUnch commented 1 year ago

GreenPad1.17beta.zip Abouteg

As usual you get a bunnch of versions, unless you are using really old systems, (NT3.1 Win32s or Chicago) anything newer that NT3.50 and Win95 should run GreenPad.exe also you got 64 bit version as well.

I am planning on making an actual release sometime soon.

DotNetTester commented 1 year ago

It's typically a dialog and not a message box. I recommend larger text with more spacing and many about dialogs have the program icon on the upper or middle left, the left of the text.

roytam1 commented 1 year ago

It's typically a dialog and not a message box. I recommend larger text with more spacing and many about dialogs have the program icon on the upper or middle left, the left of the text.

so you want a ShellAbout() dialog: image

RamonUnch commented 1 year ago

Sure but I do not know how to get rid of the Microsoft prefix. GreenPad is not made by MS...

The only thing you can change is title text + program name after Microsoft and two extra lines of info.

RamonUnch commented 1 year ago

The best I can do is:

image

If you add a # in the title string, you can set the title of the dialog and the first line separately but you must live with Microsoft ® prefix

I could write a proper help dialog.

roytam1 commented 1 year ago

for reference, a MFC application about dialog: image

RamonUnch commented 1 year ago

WIP image

roytam1 commented 1 year ago

maybe you can add a Ctrl-C handler to copy first 3 lines for diagnostics/bug reporting?

RamonUnch commented 1 year ago

Even simpler, I made relevant parts to be Edit dialogs

image

DotNetTester commented 1 year ago

WIP image

That's very close to what I was thinking about except with the text a little larger. The text would be easier for some people to read and it would look slightly nicer if it was bigger. It's true that it would be good for troubleshooting purposes to be able copy the text as well. A read only edit box, basically.

DotNetTester commented 1 year ago

The built in ShellAbout API is too clunky with extra junk that isn't needed for most about boxes. It's not the most consistent and varies in appearance from one version of Windows to the next. I personally wouldn't use it.

RamonUnch commented 1 year ago

The dialog uses the default dialog font, I can of course increase the font size but keep in mind that the dpi of y my monitor is set to 96, most people now use 120 or more meaning the font will look much larger. If the DPI setting on your screen is so small that the common dialogs appear too small to your eyes you might also consider increasing the DPI value. I can push up a little the font size but not by much before it looks out of place.

here the size is set to 10 points. GreenPad-1.17bin_beta2.zip

roytam1 commented 1 year ago

Even simpler, I made relevant parts to be Edit dialogs

image

ported to my tree( https://github.com/roytam1/rtoss/compare/master...greenpad-aboutdlg ), looks great! image image image

RamonUnch commented 1 year ago

Nice, Good idea to add OLE build flags, also you know how to write the title in Japanese, Should not the original author's name be also written in Japanese on the Japanese dialog? Also I should probably write the full name Kazuhiro Inaba on the English dialog

RamonUnch commented 1 year ago

Also for x64 built, I guess we should specify Windows NT 5.1+ because x86_64 started with XP64.

roytam1 commented 1 year ago

Should not the original author's name be also written in Japanese on the Japanese dialog?

but he called himself "k.inaba" so I don't want to change it. Ref: https://www.kmonos.net/lib/suspend.ja.html

RamonUnch commented 1 year ago

Then I agree, we must use k.inaba then.

roytam1 commented 1 year ago

Good idea to add OLE build flag

I'm thinking about adding "running on Windows X.Y.ZZZZ" on 4th line of top textbox.

RamonUnch commented 1 year ago

I'm thinking about adding "running on Windows X.Y.ZZZZ" on 4th line of top textbox.

Would be helpful indeed, I will do that.

roytam1 commented 1 year ago

Would be helpful indeed, I will do that.

cool. trying to add back the dot for msvc version. image image

RamonUnch commented 1 year ago

cool. trying to add back the dot for msvc version.

_MSC_VER info: https://dev.to/yumetodo/list-of-mscver-and-mscfullver-8nd Since Visual C++ 4.0 the formula should be (_MSC_VER-600)/100 DOT _MSC_VER%100)

String().SetInt((_MSC_VER-600)/100) + TEXT(".") + String().SetInt(_MSC_VER%100)

roytam1 commented 1 year ago

Since Visual C++ 4.0 the formula should be (_MSC_VER-600)/100 DOT _MSC_VER%100)

yeah, force pushed my branch

RamonUnch commented 1 year ago

However since Visual studio 2017 it became strange and we are still at 14.XX, even though the commercial number went to 15+

DotNetTester commented 1 year ago

The dialog uses the default dialog font, I can of course increase the font size but keep in mind that the dpi of ~y~ my monitor is set to 96, most people now use 120 or more meaning the font will look much larger. If the DPI setting on your screen is so small that the common dialogs appear too small to your eyes you might also consider increasing the DPI value. I can push up a little the font size but not by much before it looks out of place.

A size of 10 would be bigger and more readable. I personally wouldn't go above a size of 12.

There are people that switch their computers to 96 dpi due to the fact that even some new apps either break or become blurry with high DPI settings. You can lower the resolution on larger displays to make the text bigger at 96 dpi.

roytam1 commented 1 year ago

synced to my vc4-mips tree and it is working well! image

RamonUnch commented 1 year ago

1.17 released

roytam1 commented 5 months ago

Text boxes may not have gray background in NT 3.51, I added some code to deal with it. image

https://github.com/roytam1/rtoss/commit/704df7dc2bcc998b8f9acd041d926473e0bb2ba2 https://github.com/roytam1/rtoss/commit/d6edc56bf97fe5e80b13c974b9a50b43f410b633

after: image

(P.S.: in Win32s with All3D, all text boxes will be drawn in 3D normal look, and no clue to fix as it is done by external program)