search

RamonUnch / in_opus

Winamp 2.x and 5.x input plugin for Opus file
38 stars 0 forks source link

View file info doessn't close file handle #5

Open wyvernone opened 1 year ago

wyvernone commented 1 year ago

When I view an opus file info using Alt+3 in Winamp and then closing the File info window with [Cancel], the file handle remains open in Winamp and blocking any file renaming/moving in File Explorer. Any attempt with the opus file results in "The action can't be completed because the file is open in Winamp" error.

I have exit out of Winamp to perform file operation on the opus file.

Thanks for a great plug-in!

RamonUnch commented 1 year ago

Unfortunately I cannot reproduce the issue. Could you give more details.

wyvernone commented 1 year ago

Sorry. Very strange. Here I reproduce the steps:

  1. Start winamp
  2. Start sysinternals Process Explorer
  3. Find winamp in process list, click on it and press Ctrl+H to show handles
  4. Open Windows FIle Explorer, click and drag an opus file into Winamp play list window
  5. Click on file in winamp playlist editor, then press Alt+3 to show File Info window
  6. Click Cancel to close File Info window.
  7. Go back to Windows File Explorer, try to rename the opus file and get error message.
  8. Look at Process Explorer file handle list and see the file open in the lower pane
  9. Go to winamp, drag in other files and play them, skip to next, etc.
  10. Observe opus file handle in winamp process still stays there while others get closed after winamp play the file
RamonUnch commented 1 year ago

Which Winamp version are you using? I tried with Winamp5.666 and Winamp2.95. When I look at the number of Handles it always go back to the previous when stopping playback or when closing the file info dialog. And I can always rename files unless it is currently playing in Winamp. Even when the alt+3 dialog is opened the file can be renamed (which is expected behavior because in_opus closes the file handle as soon as it filled all the information).

So whatever I do I do not see your behavior. I will try to make a debug version for you to test.

wyvernone commented 1 year ago

Ah... I am using winamp 5.9.0 Build 9999 (x86)

Px-x64 commented 8 months ago

The issue is 10+ years old, and in Winamp itself https://forums.winamp.com/forum/winamp/winamp-bug-reports/305915-problem-deleting-embedded-cover-art-flac-undesired-file-locking-various-formats?p=4150585#post4150585