Ramotion / animated-tab-bar

:octocat: RAMAnimatedTabBarController is a Swift UI module library for adding animation to iOS tabbar items and icons. iOS library made by @Ramotion
https://www.ramotion.com/animated-tab-bar-ios-app-development-ui-library/
MIT License
11.13k stars 1.33k forks source link

hidesBottomBarWhenPushed don't work #213

Closed kaich closed 6 years ago

kaich commented 6 years ago

I use hidesBottomBarWhenPushed = true. But it doesn't work. I find your content is added to View of UITabBarController. And your custom container's height is 49. I think you can add container on tabbar. I change the source code as below.

    fileprivate func createViewContainer() -> UIView {
        let viewContainer = UIView()
        viewContainer.backgroundColor = UIColor.clear // for test
        viewContainer.translatesAutoresizingMaskIntoConstraints = false
        viewContainer.isExclusiveTouch = true
        tabBar.addSubview(viewContainer)

But new bug occurs. Hope you fix hidesBottomBarWhenPushed bug

xgoo commented 6 years ago

Me too...

0ber commented 6 years ago

Duplicate of #144