search

Ramotion / animated-tab-bar

:octocat: RAMAnimatedTabBarController is a Swift UI module library for adding animation to iOS tabbar items and icons. iOS library made by @Ramotion
https://www.ramotion.com/animated-tab-bar-ios-app-development-ui-library/
MIT License
11.12k stars 1.33k forks source link

RamAnimatedTabBar crashed my app when I turn to landscape #243

Closed matvdg closed 5 years ago

matvdg commented 5 years ago

My app is only in portrait mode, except for a single view overriding the orientationLock to .allButUpsideDown.

I don't know yet if it's since a new version of your library, or if it's since the introduction of iOS 12 or the new Swift 4.2.1/Xcode 10.1, but when I turn my iPhone in landscape mode, the lib crashes. I found the bug by creating a breakpoint exception with the debugger command $po arg1 to find who was crashing my app, since I changed nothing and it was working fine before when turning to landscape.

The debugger output is : Unable to activate constraint with anchors <NSLayoutYAxisAnchor:0x6000031bcc80 "UIView:0x7ffd03054db0.bottom"> and <NSLayoutYAxisAnchor:0x6000031bce00 "_UILayoutSpacer:0x6000014bf1b0'UIVC-bottomLayoutGuide'.bottom"> because they have no common ancestor. Does the constraint or its anchors reference items in different view hierarchies? That's illegal.

screenshot 2018-11-05 at 16 50 48
saeid commented 5 years ago

+1

tsulok commented 5 years ago

I'm experiencing the same issue on xcode 10.2 with SDK version 4.0.2 and 5.0.0 Previously I've used 4.0.0 on Xcode10.1 without any problem.

0ber commented 5 years ago

I can't reproduce the issues in my demo project https://github.com/0ber/AnimatedTabBar-Pod-Test. Could you add PR to this demo project where reproduce this issue

cuibeihong commented 4 years ago

+1