Ramotion / animated-tab-bar

:octocat: RAMAnimatedTabBarController is a Swift UI module library for adding animation to iOS tabbar items and icons. iOS library made by @Ramotion
https://www.ramotion.com/animated-tab-bar-ios-app-development-ui-library/
MIT License
11.13k stars 1.33k forks source link

Icons become 30x30 if you make setViewControllers second/third time #284

Closed Nightstep closed 4 years ago

Nightstep commented 4 years ago

First time I set tabs to tab bar controller, iconView is created from image size of tab item (for me icons 24x24), but if I want to insert a new tab, I put the same tabs(+ 1 new to insert) into setViewControllers method, and iconView is creating again but with default size (30x30), because item.image? doesn't exist. Maybe it makes sense to avoid iconView recreation here? Because it looks weird, when icons become bigger after next setViewControllers call?

image

Nightstep commented 4 years ago

Seems it was old version, after update seems it's working fine