search

Ramotion / paper-onboarding-android

:octocat: PaperOnboarding is a material design slider made by @Ramotion
https://www.ramotion.com/paper-onboarding-android/
MIT License
2.56k stars 421 forks source link

Updating Paper-onboarding features for Android #17

Closed StreethawkNick closed 7 years ago

StreethawkNick commented 7 years ago

Since Paper-onboarding iOS version is different to Android in terms of features:

 ("BIG_IMAGE1", "Title", "Description text", "IconName1", "BackgroundColor", textColor, DescriptionColor, textFont, DescriptionFont)

I have added TypeFace and Color features to text and description. This will make the Android version look consistent.

rockerhieu commented 7 years ago

I don't think we should hard code the typeface but let the theme decide instead.

StreethawkNick commented 7 years ago

i think it should be consistent with iOS. Why have Android's version of Paper-onboarding different to the iOS?

asyncmind0 commented 7 years ago

@rockerhieu I think it falls back to theme value if typeface is not give. Am I right @StreethawkNick

rockerhieu commented 7 years ago

@jagguli only if the widget constructor accept the origin context (activity, contextwrapper...). Right now it always uses context.getApplicationText() and that's the problem.

StreethawkNick commented 7 years ago

Will close this Pull Request in support of the other Pull Request https://github.com/Ramotion/paper-onboarding-android/pull/21 @rockerhieu