search

Rampastring / WorldAlteringEditor

Map editor for C&C: Red Alert 2, C&C: Tiberian Sun and Dawn of the Tiberium Age.
Other
70 stars 19 forks source link

Error when opening map #145

Closed ismail-doitbig closed 4 months ago

ismail-doitbig commented 5 months ago

image [5] Snarks Second Tower Defense_b667cf10e1e2946f6105324d7d6479e14c904c68.zip

vananasun commented 5 months ago

It may be better to just display these minor map ini errors in a dialog box similar to the error/warning box upon saving

ZivDero commented 5 months ago

It may be better to just display these minor map ini errors in a dialog box similar to the error/warning box upon saving

It is by design that this crashes the editor. It is left to the user to fix issues with rules.

ismail-doitbig commented 5 months ago

This map is runnable in cncnet so it should be editable?

It would make sense if it doesn't run in cncnet that it would be uneditable until it's fixed

But if it runs in cncnet there's no reason it shouldn't run in the editor

ZivDero commented 5 months ago

This map is runnable in cncnet so it should be editable?

It would make sense if it doesn't run in cncnet that it would be uneditable until it's fixed

But if it runs in cncnet there's no reason it shouldn't run in the editor

There are certain bugs that the game tolerates, but the editor does not. This is per design. Fix the bug (in this case, list the weapon)

ismail-doitbig commented 5 months ago

I'm not the original editor of this map and i dont know what to even put there. I'm just trying to edit someone else's map.

Probably it's some dead code from him.

So you're saying this is a WONTFIX ?

It would be nicer if the editor was as flexible as the game itself

ZivDero commented 5 months ago

I'm not the original editor of this map and i dont know what to even put there. I'm just trying to edit someone else's map.

Probably it's some dead code from him.

So you're saying this is a WONTFIX ?

It would be nicer if the editor was as flexible as the game itself

This was discussed but was decided that the current approach is better, so yes, this is WAD. The weapon that something is upposed to use is non-existent, so just change it.

Rampastring commented 5 months ago

Generally WAE uses a "fail fast" design, iow. if something is misconfigured, it gives an error instead of working around them.

This is usually helpful also to users because it allows them to get quickly informed of mistakes in their INI code. In this case, if the author of the map used WAE, they would have been aware of their missing weapon definition.

However, this design is a bit of a problem when editing existing community maps with flawed code. Especially if they are opened by someone who is not very familiar with INI configuration.

In this case, it can be fixed by opening the map file in Notepad, searching for the flawed weapon (BlackHawkGun), deleting the found ElitePrimary=BlackHawkGun INI key entry, and saving the map.

The resulting map can be opened in WAE.

@ismail-doitbig I've attached the fixed map below:

b667cf10e1e2946f6105324d7d6479e14c904c68.zip

ismail-doitbig commented 4 months ago

if this is WAD i'll close it