search

RamseyInHouse / scut

Sass utilities for the frontend laborer.
https://ramseyinhouse.github.io/scut/
MIT License
769 stars 61 forks source link

Remove all margins instead of only vertical ones #186

Closed f-liva closed 9 years ago

davidtheclark commented 9 years ago

Why do you want to make this change?

f-liva commented 9 years ago

I think the unstyled list (with margin removal set to true) should remove all margins in addition to the padding. What do you think?

davidtheclark commented 9 years ago

Sure, but I think that to reset default styles we only have to alter top and bottom margins and left padding. Have a look at the discussion here: https://github.com/davidtheclark/scut/issues/120. There are some downsides of being too aggressive with this resetting unless a particular use-case calls for it.

f-liva commented 9 years ago

I hadn't considered this, I'm now convinced of the correctness of the implemented unstyling. Sorry for the time :)

davidtheclark commented 9 years ago

No problem!

On Tue, Jul 7, 2015 at 1:55 PM, Federico Liva notifications@github.com wrote:

I hadn't considered this, I'm now convinced of the correctness of the implemented unstyling. Sorry for the time :)

— Reply to this email directly or view it on GitHub https://github.com/davidtheclark/scut/pull/186#issuecomment-119336282.