RamseyInHouse / scut

Sass utilities for the frontend laborer.
https://ramseyinhouse.github.io/scut/
MIT License
769 stars 61 forks source link

Make compatible with sass eyeglass #194

Closed strarsis closed 8 years ago

strarsis commented 9 years ago

It would be nice to make this also compatible with the new upcoming sass eyeglass. https://github.com/sass-eyeglass/eyeglass#writing-an-eyeglass-module-with-sass-files

davidtheclark commented 9 years ago

An effort was already made to add eyeglass support: https://github.com/davidtheclark/scut/blob/master/CHANGELOG.md#120. Does it not work for you?

strarsis commented 9 years ago

The layout was different than in ohter modules so I incorrectly deduced eyeglass support is missing.

So it works indeed with eyeglass, one thing though, I get a message when compiling:

The following modules did not declare an eyeglass version:
scut
Please add the following to the module's package.json:
  "eyeglass": { "needs": "^0.7.1" }
davidtheclark commented 9 years ago

PR welcome.

strarsis commented 9 years ago

https://github.com/davidtheclark/scut/pull/196

jmmcduffie commented 8 years ago

@davidtheclark: #196 looks good to me. Any problems with me merging it?

davidtheclark commented 8 years ago

@jmmcduffie: Nope. Merge away.

xzyfer commented 8 years ago

@jmmcduffie sorry I missed this. I had a few minutes I figured I'd a new patch release.