RamsinghLab / arkas

This is the kallisto package
0 stars 0 forks source link

sra header converti for missing run IDS #19

Closed arcolombo closed 8 years ago

arcolombo commented 8 years ago

so sra files have no run Ids e.g. @SRR892995.2 HWI-ST601:8:1101:1238:2144 length=100 , putting in a patch to fix this sraheaderconvert.

arkas assumes SRA files have run IDs e.g @SRR1564893.1 HWI-ST972:1180:D225DACXX:7:1101:1247:2104 length=50 , so need to have a flag.

arcolombo commented 8 years ago

so to make things even worse this specific header file

@SRR892995.2 HWI-ST601:8:1101:1238:2144 length=100

is missing the lane. so it seems like the true best solution must give users control to overwrite the header for each column, as opposed to assuming the SRA header has all 10 required columns.
on my branch I added a boolean to flag if the SRA header has the run ID.
one solution is to have parameters for Lane number

then this would allow users to select the lane number (could be a dummy), and arkas could force a bogus/dummy run-number and run-ID.

the required columns must be : @machine:run-number:run-ID:lane:tile-num:xposition:yPosition 1:N:0:1 so essential the only thing arkas should preserve from SRA is the tile-number, and tile positions.

sigh. so frustrating and so stupid. but necessary stupid. sort of making a simple process more complex than my desires.......

ttriche commented 8 years ago

as simple as possible, but no simpler

--t

On Tue, Jul 19, 2016 at 9:08 AM, Anthony R. Colombo < notifications@github.com> wrote:

so to make things even worse this specific header file

@SRR892995.2 HWI-ST601:8:1101:1238:2144 length=100

is missing the lane. so it seems like the true best solution must give users control to overwrite the header for each column, as opposed to assuming the SRA header has all 10 required columns.

on my branch I added a boolean to flag if the SRA header has the run ID.

one solution is to have parameters for Lane number

then this would allow users to select the lane number (could be a dummy), and arkas could force a bogus/dummy run-number and run-ID.

the required columns must be : @machine https://github.com/machine:run-number:run-ID:lane:tile-num:xposition:yPosition 1:N:0:1 so essential the only thing arkas should preserve from SRA is the tile-number, and tile positions.

sigh. so frustrating and so stupid. but necessary stupid. sort of making a simple process more complex than my desires.......

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/19#issuecomment-233682884, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIs3XrP9KDE3G1Ff6D5qgYPKqg7Xdks5qXPZqgaJpZM4JPURp .

arcolombo commented 8 years ago

thebride

okay

arcolombo commented 8 years ago

the current patch I have is working handy, just use a single boolean flag, if the flag is true, then it runs a specific shell script which handles a dummy addition of runNumber and runID for this specific use case. if the flag is false then the runID exists, and most likely the run number does too. upcoming PR will close this.... mouse data is being uploaded currently. upload time is not very fast....

arcolombo commented 8 years ago

closing due to PR