RamsinghLab / arkas

This is the kallisto package
0 stars 0 forks source link

arkas::rowRanges is not compatible with GenomicFeatures::rowRanges #42

Closed arcolombo closed 8 years ago

arcolombo commented 8 years ago

if you use library(matrixStats) this will over-write the arkas namespace of rowRanges, and thus rowRanges(arkas.kexp) will fail Argument 'x' must be a matrix or a vector.

GenomicFeatures use of rowRanges is not compatible with arkas::rowRanges for sum reasons

ttriche commented 8 years ago

I think we have to explicitly namespace matrixStats::rowRanges()

At some point I started habitually doing so, as with igraph::graph.data.frame(). It may be worthwhile for BiocGenerics to register a rowRanges generic and promote matrixStats' function thusly

--t

On Tue, Aug 23, 2016 at 5:10 PM, Anthony R. Colombo < notifications@github.com> wrote:

if you use library(matrixStats) this will over-write the arkas namespace of rowRanges, and thus rowRanges(arkas.kexp) will fail Argument 'x' must be a matrix or a vector.

GenomicFeatures use of rowRanges is not compatible with arkas::rowRanges for sum reasons

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIuUtCJ-gVqkQWsKZtVZnoROlvA9Tks5qi4v9gaJpZM4Jrg_I .

arcolombo commented 8 years ago

yes that how I was able to solve using your byMads, with a specific call.

so if someone , a general user, calls library(matrixStats) and it blows out arkas<SummarizedExperiment::rowRanges, is this our problem?

On Tue, Aug 23, 2016 at 5:37 PM, Tim Triche, Jr. notifications@github.com wrote:

I think we have to explicitly namespace matrixStats::rowRanges()

At some point I started habitually doing so, as with igraph::graph.data.frame(). It may be worthwhile for BiocGenerics to register a rowRanges generic and promote matrixStats' function thusly

--t

On Tue, Aug 23, 2016 at 5:10 PM, Anthony R. Colombo < notifications@github.com> wrote:

if you use library(matrixStats) this will over-write the arkas namespace of rowRanges, and thus rowRanges(arkas.kexp) will fail Argument 'x' must be a matrix or a vector.

GenomicFeatures use of rowRanges is not compatible with arkas::rowRanges for sum reasons

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIuUtCJ- gVqkQWsKZtVZnoROlvA9Tks5qi4v9gaJpZM4Jrg_I .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42#issuecomment-241925073, or mute the thread https://github.com/notifications/unsubscribe-auth/AFODSxLCQuwTb6NkpMz3PKCXxvGng9rzks5qi5JXgaJpZM4Jrg_I .

ttriche commented 8 years ago

no it is not, not any more than it's Marc Carlson's problem when it blows away GenomicFeatures' rowRanges method :-)

--t

On Tue, Aug 23, 2016 at 5:38 PM, Anthony R. Colombo < notifications@github.com> wrote:

yes that how I was able to solve using your byMads, with a specific call.

so if someone , a general user, calls library(matrixStats) and it blows out arkas<SummarizedExperiment::rowRanges, is this our problem?

On Tue, Aug 23, 2016 at 5:37 PM, Tim Triche, Jr. <notifications@github.com

wrote:

I think we have to explicitly namespace matrixStats::rowRanges()

At some point I started habitually doing so, as with igraph::graph.data.frame(). It may be worthwhile for BiocGenerics to register a rowRanges generic and promote matrixStats' function thusly

--t

On Tue, Aug 23, 2016 at 5:10 PM, Anthony R. Colombo < notifications@github.com> wrote:

if you use library(matrixStats) this will over-write the arkas namespace of rowRanges, and thus rowRanges(arkas.kexp) will fail Argument 'x' must be a matrix or a vector.

GenomicFeatures use of rowRanges is not compatible with arkas::rowRanges for sum reasons

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIuUtCJ- gVqkQWsKZtVZnoROlvA9Tks5qi4v9gaJpZM4Jrg_I .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42#issuecomment-241925073, or mute the thread https://github.com/notifications/unsubscribe-auth/ AFODSxLCQuwTb6NkpMz3PKCXxvGng9rzks5qi5JXgaJpZM4Jrg_I .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RamsinghLab/arkas/issues/42#issuecomment-241925247, or mute the thread https://github.com/notifications/unsubscribe-auth/AAARIsqcc-PlamcY5D-35J5Y4CiyvH4dks5qi5KigaJpZM4Jrg_I .