Ranchero-Software / NetNewsWire

RSS reader for macOS and iOS.
https://netnewswire.com/
MIT License
8.28k stars 526 forks source link

Feedly: improve error handling during authentication #1030

Open kielgillard opened 5 years ago

kielgillard commented 5 years ago

If an error occurs while authorizing NetNewsWire to access a user's Feedly account, an alert should be presented stating the problem succinctly and plainly while also offering a suggestion to help the user take an appropriate course of action. Buttons could be provided to facilitate those actions.

At the time of writing, AccountsFeedlyWebWindowController's error handling was deferred to facilitate concurrent intergration with Feedly. It should not remain like this.

brentsimmons commented 4 years ago

Is this still an issue? I’m not seeing AccountsFeedlyWebWindowController — where should I look for the code?

kielgillard commented 4 years ago

I don't remember it as an issue any more because the authentication framework handles it. But I'll check the code in the next day and let you know what's happening next.

kielgillard commented 4 years ago

Notes for self or someone else: search for the OAuthAccountAuthorizationOperationDelegate conformances. Errors received in these methods are directly presented. Some errors are created in the caller, OAuthAccountAuthorizationOperation, and could be a more user friendly.